chore: add builder for keeping track of references found #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazanne
changed the title
jazanne
commented
Nov 3, 2023
Comment on lines
-134
to
-135
| // If flag is in both added and removed then it is being modified | ||
| delete(flagsRef.FlagsRemoved, flagKey) |
There was a problem hiding this comment.
deduping "modified" flags now happens in Build()
jazanne
commented
Nov 3, 2023
| @@ -131,9 +131,7 @@ func ProcessFlags(flagsRef lflags.FlagsRef, flags []ldapi.FeatureFlag, config *l | |||
| // sort keys so hashing can work for checking if comment already exists | |||
| sort.Strings(addedKeys) | |||
| for _, flagKey := range addedKeys { | |||
| // If flag is in both added and removed then it is being modified | |||
| delete(flagsRef.FlagsRemoved, flagKey) | |||
| flagAliases := uniqueAliases(flagsRef.FlagsAdded[flagKey]) | |||
There was a problem hiding this comment.
remove duplicate or empty alias strings is now handled by Build()
LaunchDarkly flag references🔍 2 flags added or modified
❌ 1 flag removed
|
github-actions
bot
added
the
ld-flags
jazanne
commented
Nov 3, 2023
| flagMap[op][flagKey][alias] = true | ||
| } | ||
| } | ||
| aliasMatches := elementMatcher.FindAliases(line, flagKey) |
There was a problem hiding this comment.
this was always supposed to be calling elementMatcher.FindAliases - since we don't have monorepo support, it hasn't mattered so far that it wasn't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves a lot logic out of
ProcessDiffsby using a builder to track references.This allows us to use
Build()to do additional processing that other functions were doing (like deduping added/removed flags as "modified").This sets us up to handle monorepo support a lot more easily.